Add support for CocoaPods#63
Open
virginiapujols-yml wants to merge 1 commit intocodeandtheory:mainfrom
Open
Conversation
virginiapujols-yml
requested review from
DanielCardonaRojas,
EduNavaYML,
kikoso and
mpospese
mpospese
reviewed
May 5, 2023
Contributor
mpospese
left a comment
mpospese
left a comment
There was a problem hiding this comment.
I would really like to find some other way to enable this use in React Native. I don't think we want to add cocoapods support back because it complicates our release system.
| Action | Cocoapods release | SPM release |
|---|---|---|
| push tag | ❌ | ✅ |
| update .podspec | ✅ | ❌ |
pod repo push to update cocoapods directory |
✅ | ❌ |
Especially the bit about updating the .podspec file means creating an additional PR to bump the version in that file to match the tag. Whereas for SPM all we need do is push a tag to our own repo.
EduNavaYML
previously approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Add support for CocoaPods; a dependency manager for Swift and Objc
Purpose
Our aim is to provide support for CocoaPods as it is useful for React Native projects to have access to the library.
Scope
Included a new file named
YCoreUI.podspec